-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs dependencies #315
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @JaGeo , I have added a temp workaround fix for CI doc-build failures, I just upgrade monty in the workflow before executing doc-builds and it seems to work fine now. Thus this PR could be merged if you are also fine with it. We can remove this lines from our workflows once atomate2 and pymatgen issues are fixed |
JaGeo
approved these changes
Jan 4, 2025
Sure and happy Weekend @naik-aakash (sent from the car 😅) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also addresses #259 , thus that PR could be closed.
Changes
sphinx
,myst_parser
andsphinx_design
versionsNote: The doc-build still fails due to monty raising a deprecation warning (stems from pymatgen method being deprecated : clearly visible after sphinx version update in CI) > Does not affects our tests as they run inside docker container.