Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable NEP interface #288

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

naik-aakash
Copy link
Collaborator

@naik-aakash naik-aakash commented Dec 9, 2024

This PR partially addresses #54 by adding the necessary dependencies to Docker Image that can enable testing on github.

Changes

  1. Add calorine as dependency in pyproject.toml
  2. Grouped some installation commands
  3. Added flexibility to MLIPFitMaker (eg:- users can now change labels used for training data; change was needed because nep executable can only read files with .xyz extension and needs xyz file to have specific labels)

Todo

  • Add nep_fitting function in src/autoplex/fitting/common/utils.py
  • Add NEP as option in MLIPFitMaker
  • Add NEP as option in phonon and RSS workflows
  • Revert GPUMD install in the dockerfile (NEP model training only works with a GPU > thus redundant)
  • Simulate calls to nep using pytest fixtures (add mock_nep in conftest.py)

@naik-aakash naik-aakash changed the title Add dependencies to enable NEP interface Enable NEP interface Dec 9, 2024
@naik-aakash naik-aakash marked this pull request as draft December 9, 2024 08:58
@QuantumChemist
Copy link
Collaborator

Can you wait a bit with this until #280 is done? 😃

@naik-aakash
Copy link
Collaborator Author

Can you wait a bit with this until #280 is done? 😃

Yeah ofcourse, it is not priority now and I already intended to do this after #280 is merged. Thus have only added dependencies no code yet.

@naik-aakash naik-aakash added documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file labels Dec 10, 2024
@naik-aakash naik-aakash self-assigned this Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants