Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass instances #30

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Pass instances #30

wants to merge 3 commits into from

Conversation

DE0CH
Copy link
Collaborator

@DE0CH DE0CH commented Dec 23, 2022

We feed the json serialized instances list to irace but at the targetRunnerParallel end, we swap it back with the original python objects. This allows a lot more objects to be pass though the instances list while leaving the log file more or less human readable at a glance.

This is built on top of PR #22. I think since that is going to get merged soon, I won't write this PR with main as a base.

Closes #29.

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2022

Codecov Report

Merging #30 (68ff4ae) into main (b2177a6) will decrease coverage by 0.70%.
The diff coverage is 87.03%.

❗ Current head 68ff4ae differs from pull request most recent head ffff0b1. Consider uploading reports for the commit ffff0b1 to get more accurate results

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
- Coverage   92.37%   91.66%   -0.71%     
==========================================
  Files          10       11       +1     
  Lines         354      384      +30     
==========================================
+ Hits          327      352      +25     
- Misses         27       32       +5     
Impacted Files Coverage Δ
tests/utils.py 73.33% <73.33%> (ø)
src/irace/__init__.py 88.98% <86.95%> (-0.85%) ⬇️
tests/test_data_conversion.py 86.20% <100.00%> (+5.25%) ⬆️
tests/test_dual_annealing.py 94.87% <100.00%> (+1.12%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DE0CH DE0CH force-pushed the pass-instances branch 2 times, most recently from e16e146 to bfa1ff2 Compare December 26, 2022 08:42
This was referenced Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swaping the irace instances with python objects
2 participants