Add support to the core and tuple packages for relationship expiration #2146
+1,869
−1,413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api v1
tstirrat15
reviewed
Nov 26, 2024
| @@ -73,7 +73,7 @@ func (ch *Changes[R, K]) AddRelationshipChange( | |||
| return err | |||
| } | |||
|
|
|||
| key := tuple.StringWithoutCaveat(rel) | |||
| key := tuple.StringWithoutCaveatOrExpiration(rel) | |||
There was a problem hiding this comment.
I wanted to be explicit for now; if/when we add more traits, I plan to rename
Comment on lines
+157
to
+161
| for _, rel := range batch.Relationships { | ||
| if rel.OptionalExpiresAt != nil { | ||
| return nil, fmt.Errorf("expiration time is not currently supported") | ||
| } | ||
| } |
There was a problem hiding this comment.
Is this extra defensiveness for the current release?
| @@ -71,6 +71,8 @@ func TestEqual(t *testing.T) { | |||
| MustParse("document:foo#viewer@user:tom[somecaveat:{\"hi\":{\"yo\":123}}]"), | |||
| MustParse("document:foo#viewer@user:tom[somecaveat:{\"hi\":{\"yo\":{\"hey\":true}}, \"hi2\":{\"yo2\":{\"hey2\":false}}}]"), | |||
| MustParse("document:foo#viewer@user:tom[somecaveat:{\"hi\":{\"yo\":{\"hey\":true}}, \"hi2\":{\"yo2\":{\"hey2\":[1,2,3]}}}]"), | |||
| MustParse("document:foo#viewer@user:tom[expiration:2020-01-01T00:00:00Z]"), | |||
| MustParse("document:foo#viewer@user:tom[somecaveat:{\"hi\":\"there\"}][expiration:2020-01-01T00:00:00Z]"), | |||
There was a problem hiding this comment.
Are we doing separate brackets for each trait? I'd be in favor of having them within the same set of brackets and comma-separated like in the first example from slack.
There was a problem hiding this comment.
Yeah, I felt each bracket made it more readable (and makes it easier to parse)
vroldanbet
reviewed
Nov 27, 2024
josephschorr
force-pushed
the
rel-expiration-core
branch
2 times, most recently
from
b670eaa
to
4ba2457
Compare
josephschorr
force-pushed
the
rel-expiration-core
branch
from
4ba2457
to
f3b5c44
Compare
vroldanbet
approved these changes
Nov 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.