Ensure AsyncAgedCache is correctly updated (#693)

auth0 · Jan 10, 2024 · 24a6502 · 24a6502
1 parent 36c8767
commit 24a6502
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/src/Auth0.AuthenticationApi/Tokens/AsyncAgedCache.cs b/src/Auth0.AuthenticationApi/Tokens/AsyncAgedCache.cs
@@ -28,6 +28,9 @@ public Task<TValue> GetOrAddAsync(TKey key, TimeSpan maxAge)
                 var cacheExpiresAt = entry.CachedAt.Add(maxAge);
                 if (now < cacheExpiresAt)
                     return entry.Task;
+
+                // When a cache entry was found, but expired, we want to remove it.
+                cache.TryRemove(key, out _);
             }
 
             var task = valueFactory(key);

diff --git a/tests/Auth0.AuthenticationApi.IntegrationTests/Tokens/AsyncAgedCacheTests.cs b/tests/Auth0.AuthenticationApi.IntegrationTests/Tokens/AsyncAgedCacheTests.cs
@@ -32,6 +32,28 @@ public async Task DoesNotCallFactoryWhenAlreadyCached()
             await cache.GetOrAddAsync("abc", TimeSpan.FromSeconds(30));
             Assert.Equal(1, factoryCallCount);
         }
+
+        [Fact]
+        public async Task CorrectlyUpdatesTheCache()
+        {
+            var factoryCallCount = 0;
+            Task<int> factory(string s) => Task.FromResult(factoryCallCount++);
+            var cache = new AsyncAgedCache<string, int>(factory);
+
+            await cache.GetOrAddAsync("abc", TimeSpan.FromSeconds(1));
+            Assert.Equal(1, factoryCallCount);
+            await cache.GetOrAddAsync("abc", TimeSpan.FromSeconds(1));
+            Assert.Equal(1, factoryCallCount);
+
+            // Wait 2 sec
+            await Task.Delay(2000);
+            factoryCallCount = 0;
+
+            await cache.GetOrAddAsync("abc", TimeSpan.FromSeconds(1));
+            Assert.Equal(1, factoryCallCount);
+            await cache.GetOrAddAsync("abc", TimeSpan.FromSeconds(1));
+            Assert.Equal(1, factoryCallCount);
+        }
 
         [Fact]
         public async Task DoesNotCallFactoryWithWrongKey()