Add MSVC coverage for Constant and UnitSymbol
#363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some comments on the vcpkg PR to upgrade Au to 0.4.0 made me suspicious that we lacked coverage here. I'm going to add it and see if it breaks.
chiphogg
added
the
release notes: ⚙️ repo
timhirsh
approved these changes
Dec 18, 2024
chiphogg
added a commit
that referenced
this pull request
Dec 18, 2024
I went through every `static_assert` in our C++ files, and added MSVC test coverage for any that looked like they might be vulnerable to the same error as in #363. I added these test cases one at a time, so I could tell which ones failed. - The `is_known_to_be_less_than_one` "bug" never actually failed, whether I called it directly or indirectly. I'm leaving the tests in place, and I "fixed" it anyway because it made the function body more stylistically consistent. - The `inverse_as`/`inverse_in` bug was indeed another instance of this problem. Now we have coverage and a fix. Fixes #364.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some comments on the vcpkg PR to upgrade Au to 0.4.0 made me suspicious
that we lacked coverage here. I added a test case, and sure enough, it
broke.
What's happening here is that MSVC is being extremely persnickety
about what we pass to a
static_assert. We are passing a functionparameter, which in the general case might be a runtime value;
hence, inappropriate for
static_assert.What MSVC doesn't know is that
OtherUnitis a monovalue type, so itcan only ever have one possible value, and therefore that value is
knowable at compile time. That said, since it is a monovalue type,
that means that it's safe to replace the instance
uwith an ad hocconstruction of the type name,
OtherUnit{}. This appeases MSVC.Helps #364: we'll go over every other
static_assertbefore closing.