Use a simple indexed loop #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently, some platforms struggle with range-based `for` loops on C-style arrays. Other platforms don't seem to like the C-style array at all, so we're trying a `std::array`. You'd think we'd be able to use range-for with this... but, no, `begin` isn't `constexpr` until C++17, so we're using an indexed loop anyways. Follow-up for #217.
chiphogg
added
the
release notes: 🐛 lib (bugfix)
geoffviola
approved these changes
Nov 23, 2024
geoffviola
reviewed
Nov 25, 2024
| // First, do trial division against the first N primes. | ||
| for (const auto &p : first_primes) { |
There was a problem hiding this comment.
Q: Which compiler didn't support C-Style arrays? It seems OK for clang and gcc: godbolt.
std::array is generally recommended per the cppcoreguidelines. But I don't like that the length has to be specified in C++14. It doesn't in C++17 😄
There was a problem hiding this comment.
Good question! I slacked you the (Aurora-internal) build log. I think it was NvccCompile choking on the particular way that we were using the array. It was complaining about an incomplete type, but I didn't want to mess with it and decided to just try using std::array instead. 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, some platforms struggle with range-based
forloops onC-style arrays. Other platforms don't seem to like the C-style array at
all, so we're trying a
std::array. You'd think we'd be able to userange-for with this... but, no,
beginisn'tconstexpruntil C++17,so we're using an indexed loop anyways.
Tested on the Aurora-internal code that revealed the problem.
Follow-up for #217.