Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest change is that we add a new section for the new kind of
error, when users try to pass something to a
QuantityMaker
even thoughit's already a
Quantity
(and similar forQuantityPoint
).We also update the guidance to recommend
unblock_int_div
instead ofthe obsolete
integer_quotient
.Other than that, the PR basically consists of running the build under
the five configurations shown here, and copy-pasting error messages.
Most changes are just line number tweaks. Some changed implementation
details do show up in the error messages. Also, sometimes the compiler
changed to be more or less verbose.
The details of the changes aren't really important (assuming that I
copy-pasted correctly). It's just an update.
Fixes #288.