Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically include <iostream> in godbolt link #291

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

chiphogg
Copy link
Contributor

This eliminates the main annoyance in my personal use of the godbolt
link, and I suspect many others' too.

Fixes #290.

This eliminates the main annoyance in my personal use of the godbolt
link, and I suspect many others' too.

Fixes #290.
@chiphogg chiphogg requested a review from geoffviola September 14, 2024 19:08
Copy link
Contributor

@geoffviola geoffviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to optimize your experience. I typically use cout as well.

There may be some std::fputs users that prefer a smaller binary size. If there are issues, we can revisit that later.

@chiphogg chiphogg merged commit 5cbc0e6 into main Sep 16, 2024
10 checks passed
@chiphogg
Copy link
Contributor Author

Yep, I don't think it matters too much; all we need is a reasonable default.

@chiphogg chiphogg deleted the chiphogg/iostream#290 branch September 16, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include iostream in canonical godbolt link
2 participants