Change compiler naming scheme for MSVC #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been calling the version on Windows Server 2022, "MSVC x64 19.35". Well, apparently it's now running 19.40, not 19.35. If this can change without our knowing, then putting the version number in the name is probably not a great idea. An alternative suggestion was to use the version of Windows Server in the name, since that won't ever change. We do that here. This will break the continuity for the page giving historical results per job, i.e., it will create a "new job". I'm not especially concerned about that. Fixes #283.
chiphogg
added
the
release notes: ⚙️ repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been calling the version on Windows Server 2022, "MSVC x64 19.35".
Well, apparently it's now running 19.40, not 19.35. If this can change
without our knowing, then putting the version number in the name is
probably not a great idea.
An alternative suggestion was to use the version of Windows Server in
the name, since that won't ever change. We do that here.
This will break the continuity for the page giving historical results
per job, i.e., it will create a "new job". I'm not especially concerned
about that.
Fixes #283.