Skip to content

Commit

Permalink
Fetch gcc toolchain from archive/ URL (#287)
Browse files Browse the repository at this point in the history
Previously, we were using the `tarball/` URL, which includes both the
organization and the repo name as part of the prefix.  GitHub also has
an `archive/` URL format which, according to this [comment], only
includes the repo name, not the organization!

This PR switches to the new format, making us less vulnerable to build
breakage if the repo changes homes again.  (Notice how `f0rmiga` never
appears except in the URL --- in particular, it is now absent from
`strip_prefix`.)  The even better solution would be to download stable
tarballs from the release page, but the project has not yet begun to
provide those.

[comment]:
f0rmiga/gcc-toolchain#165 (comment)
  • Loading branch information
chiphogg authored Aug 15, 2024
1 parent f267ebc commit d360717
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,11 @@ http_archive(
patches = [
"@//:third_party/aspect_gcc_toolchain/0001-Expose-target_settings-and-set-std-c-14.patch",
],
sha256 = "9c075a67d401d1aa8b4935cc520e9926b1926fba72c1ab609400b239c92f5639",
strip_prefix = "f0rmiga-gcc-toolchain-ac745d4",
sha256 = "0651c0d595417b71fdbd903bf852c59a4a576a82e15651bd9672416b64019530",
strip_prefix = "gcc-toolchain-ac745d4685e2095cc4f057862800f3f0a473c201",
type = "tar.gz",
urls = [
"https://github.com/f0rmiga/gcc-toolchain/tarball/ac745d4685e2095cc4f057862800f3f0a473c201",
"https://github.com/f0rmiga/gcc-toolchain/archive/ac745d4685e2095cc4f057862800f3f0a473c201.tar.gz",
],
)

Expand Down

0 comments on commit d360717

Please sign in to comment.