Feat: add EIP-7623 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birchmd
reviewed
Jan 21, 2025
src/executor/stack/executor.rs
Outdated
| } | ||
|
|
||
| /// Get fee needed for the current executor, given the price. | ||
| pub fn fee(&self, price: U256) -> U256 { | ||
| pub fn fee(&mut self, price: U256) -> U256 { |
There was a problem hiding this comment.
Why does this need to be mutable now?
There was a problem hiding this comment.
Good catch! After new tests peactra-devnet-5-1.2.0 some logic was changed. I cleared mut in other places. And that line just forget. Funny that clippy didn't warn it.
birchmd
approved these changes
Jan 21, 2025
aleksuss
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
➡️ Added EIP-7623 for Prague hard fork.
➡️ Extended tests for
EIP-7623.