Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: tests for EIP-3860 #41

Merged
merged 5 commits into from
May 20, 2024
Merged

Fix: tests for EIP-3860 #41

merged 5 commits into from
May 20, 2024

Conversation

mrLSD
Copy link
Member

@mrLSD mrLSD commented May 16, 2024

Description

Fixed tests for EIP-3860.

↪️ Realted to Cancun implenentation PRs: #39 and #40

@mrLSD mrLSD self-assigned this May 16, 2024
@mrLSD mrLSD added the tests label May 16, 2024
@mrLSD mrLSD changed the base branch from master to feat/evm-tests May 16, 2024 11:32
@mrLSD mrLSD requested review from aleksuss and birchmd May 16, 2024 11:35
evm-tests/jsontests/src/state.rs Outdated Show resolved Hide resolved
evm-tests/jsontests/src/state.rs Outdated Show resolved Hide resolved
evm-tests/jsontests/src/state.rs Outdated Show resolved Hide resolved
@mrLSD
Copy link
Member Author

mrLSD commented May 20, 2024

Thanks @birchmd about ExitReason point. I'll take it for some more refactoring in the nearest PR for tests.

Copy link
Member

@aleksuss aleksuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good with a tiny nitpick.

evm-tests/jsontests/src/state.rs Outdated Show resolved Hide resolved
@mrLSD mrLSD merged commit 6ea09a0 into feat/evm-tests May 20, 2024
3 checks passed
@mrLSD mrLSD deleted the fix/eip-3860 branch May 24, 2024 22:28
mrLSD added a commit that referenced this pull request May 28, 2024
* Extend tests output and refactore tests runner

* Refactored CLI for recursive tests and extended information

* Set Shanghai spec as default

* Extend output for tests

* evm-tests: extend state statistics for failed results

* evm-tests: extended debug info

* Extend gas cost analyzer

* Extend tests and fixes for Cancun hard fork

* Fix: Apply CREATE storage reset - changed logic. GAS cost for MCOPY - improved calculation

* EIP-3607 implementation. DeepCall bug fixes. KZG-boilerplate

* KZG precompile

* Removev debug info

* Fix: tests for EIP-3860 (#41)

undefined

* ForkSpec string error. Refactored usage as constantn USIZE_MAX

* Remove already fixed tests from skipping list

* Added KzgInput
@mrLSD mrLSD mentioned this pull request May 28, 2024
2 tasks
mrLSD added a commit that referenced this pull request Jun 5, 2024
* Extend tests output and refactore tests runner

* Refactored CLI for recursive tests and extended information

* Set Shanghai spec as default

* Extend output for tests

* evm-tests: extend state statistics for failed results

* evm-tests: extended debug info

* Extend gas cost analyzer

* Extend tests and fixes for Cancun hard fork

* Fix: Apply CREATE storage reset - changed logic. GAS cost for MCOPY - improved calculation

* EIP-3607 implementation. DeepCall bug fixes. KZG-boilerplate

* KZG precompile

* EIP-3860 test flow fixes

* Fix Shanghai tests

* Removev debug info

* Separate check_exit_reason func

* Remove printing

* Added `as_deref`  to  check_create_exit_reason

* Fix: tests for EIP-3860 (#41)

undefined

* ForkSpec string error. Refactored usage as constantn USIZE_MAX

* Remove already fixed tests from skipping list

* Refactore blob-hash logic and tests

* Added KzgInput

* Gas price fix and investigations for blob-transactions

* Refactored skipped-match and clippy

* Refactored gas price and should-skip logic

* Fix tests for KZG-precompiles and SSTORE gas cost

* Added print-debug feature

* Fix randomness validation

* Refactore transactions validation

* Extend expected check for call-transaction and empty-create assertion

* Edit doc comments
mrLSD added a commit that referenced this pull request Jun 11, 2024
* Extend tests output and refactore tests runner

* Refactored CLI for recursive tests and extended information

* Set Shanghai spec as default

* Extend output for tests

* evm-tests: extend state statistics for failed results

* evm-tests: extended debug info

* Extend gas cost analyzer

* Extend tests and fixes for Cancun hard fork

* Fix: Apply CREATE storage reset - changed logic. GAS cost for MCOPY - improved calculation

* EIP-3607 implementation. DeepCall bug fixes. KZG-boilerplate

* KZG precompile

* EIP-3860 test flow fixes

* Fix Shanghai tests

* Removev debug info

* Separate check_exit_reason func

* Remove printing

* Added `as_deref`  to  check_create_exit_reason

* Fix: tests for EIP-3860 (#41)

undefined

* ForkSpec string error. Refactored usage as constantn USIZE_MAX

* Remove already fixed tests from skipping list

* Refactore blob-hash logic and tests

* Added KzgInput

* Gas price fix and investigations for blob-transactions

* Refactored skipped-match and clippy

* Refactored gas price and should-skip logic

* Fix tests for KZG-precompiles and SSTORE gas cost

* Added print-debug feature

* Fix randomness validation

* Refactore transactions validation

* Extend expected check for call-transaction and empty-create assertion

* Edit doc comments

* Refactore CLI tool for test run

* remove vm-tests

* update vm-tests validations

* remove state tests

* Remove submodule: ethtests

* Update CI rules

* Update CI rules

* Update Cargo metadata

* Update cargo features
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants