Skip to content

Commit

Permalink
Also support webpack 2
Browse files Browse the repository at this point in the history
  • Loading branch information
@martijnboland
martijnboland committed Feb 25, 2016
1 parent 5ac9ef6 commit dc945fe
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"url": "http://github.com/aurelia/webpack-plugin"
},
"dependencies": {
"webpack": ">= 1.12 < 3"
"webpack": ">=1.12 <3"
},
"devDependencies": {
"aurelia-tools": "^0.1.18",
Expand Down

4 comments on commit dc945fe

@stoffeastrom
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martijnboland why would this support webpack 2? It's still installing 1.12.14 even if the consumer has "webpack": "^2.1.0-beta.4"

Should this be under peerDependencies?

@martijnboland
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing it's installing 1.12.14 because it's the latest stable version? What do you mean by 'the consumer has webpack 2.1.0-beta.4"? Is it installed globally?

@stoffeastrom
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit says it support webpack 2 but how should I do to actually get that installed? If I put the beta version in package.json it will install 1.12.14 as you say. Maybe it will work when it's not beta anymore?. If it were a peer dependency it would be up to the "consumer" to provide the plugin with a version.. just my thoughts then I guess it would have worked even with the beta version

@martijnboland
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You make a good point about making webpack a peer dependency. Might be the better option.
I just installed webpack beta with 'npm install [email protected] --save' and that does properly install the beta version, but aurelia-webpack-plugin will indeed still use 1.12.14 internally (and throw the 'No module factory available for dependency type: ContextElementDependency' exception).

Please sign in to comment.