-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to 6.0.280. Fix rejected patch for MPRIS #91
base: master
Are you sure you want to change the base?
Conversation
Hello @asyd and @josselinonduty. I'm sorry for not updating anything for the last months or so, I'm a bit lost with flatpak development (and bored with technology in general...). I don't think I have the will to continue updating this repo right now, and I will break havok if I try to touch anything myself. @randshell: you have already changed things about the repo before and you seem to know how things work (i do not), so I was wondering if you were okay to take care about it and make it work again? I think I can give you the write access to the repo, and to https://github.com/flathub/dev.aunetx.deezer too. If @asyd or @josselinonduty want to take the responsibility instead, that's good for me too. I know it is not the common way to fix problems, but I don't see myself diving into it to be honest so there may not be another solution... |
Salut ! Thanks for letting us know and for your honesty, always appreciated 🫶 However, it would be nice to co-maintain it with someone more experienced in Flatpak dev than me since I have never really used it apart from small things. Let's ear what @asyd and @randshell have to tell! |
Hey @aunetx, first of all thank you for all the work you've put into this project! I generally have limited time myself, but I'd be happy to give some feedback or hack something together when I can. I'm more of an enthusiast and homelabber than actual developer though, so I agree with @asyd and @josselinonduty that it'd be nice to be able to co-maintain instead. Actually, I think it'd be possible to keep the repo nice and clean with branch protection rules, which might give you some peace of mind as well. For example, configuring a rule so that we'd be able to open PRs against main rather than allowing direct pushing, and perhaps also the option of 1 mandatory approval from another maintainer before merge? What do you think? |
I agree, branch protection, mandatory approval and in general discussion before decision would be great additions. Also, if we manage to find some time for it, ci/cd with testing on different platforms would be nice! |
mpris.patch on
app/package.json
was rejected becauseobject.assign
is not anymore in dependenciesedit: I think you should check for any
.rej
files inapp
directory to fail the build