Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 394 adjusted grades with max possible grade and numeric value #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix issue 394 adjusted grades with max possible grade and numeric value #1

wants to merge 3 commits into from

Conversation

lkatsikaris
Copy link

@lkatsikaris lkatsikaris commented Aug 20, 2024 •
edited
Loading

TL;DR - [ A short summary of what this PR does and why ]

JIRA: JIRA-XXXX

What changed?

  • Fixed the adjusted grade by comparing the input value with the possibleGrade (the maximum grade can take) and enabling the save button only if the value is minor than the possibleGrade.
  • Modify the useAdjustedGradeInputData hook to return the possible grade that we need in the comparison above.

image

image

image

Developer Checklist

  • Test suites passing
  • Documentation and test plan updated, if applicable
  • Received code-owner approving review
  • Bumped version number package.json

Testing Instructions

[ How should a reviewer test this PR? ]

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

@lkatsikaris lkatsikaris changed the title Lkatsikaris/issue 394 Fix issue 394 adjusted grades with max possible grade and numeric value Aug 26, 2024
@lkatsikaris lkatsikaris force-pushed the lkatsikaris/issue-394 branch from 0c42265 to 35028b5 Compare August 27, 2024 12:48
@lkatsikaris lkatsikaris force-pushed the lkatsikaris/issue-394 branch from 32ccae5 to d0a26cc Compare October 28, 2024 13:22
@lkatsikaris lkatsikaris force-pushed the lkatsikaris/issue-394 branch from d0a26cc to b645d5d Compare October 30, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lkatsikaris @brian-smith-tcril @edx-requirements-bot