Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AV-1434-Change-Home-page-content-with-Abe-s-update-Website #612

Conversation

jlaverde77
Copy link
Contributor

No description provided.

- Added image.
- Created superHero button style class.
@jlaverde77 jlaverde77 requested a review from alangumer as a code owner January 6, 2025 20:44
Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
audioverse-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 2:29pm

Copy link

github-actions bot commented Jan 6, 2025

Localization Summary

language unchanged added removed untranslated
br 871 3 4 80
de 871 3 4 412
en 870 3 4 0
es 871 3 4 403
fr 871 3 4 420
ja 871 3 4 383
ru 871 3 4 393
zh 871 3 4 382

View full summary

Copy link

github-actions bot commented Jan 7, 2025

📦 Next.js Bundle Analysis for audioverse-next

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 259.21 KB (🟡 +69 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Page Added

The following page was added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (225 KB)
/[language]/playlists/[playlist]/feed.xml 271 B 259.47 KB 115.32%

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (225 KB)
/[language] 10.48 KB 269.69 KB 119.86% (🟢 -0.04%)
/[language]/library/playlists/[playlist] 5.63 KB 264.84 KB 117.71% (+/- <0.01%)
/[language]/playlists/[playlist] 5.12 KB 264.32 KB 117.48% (+/- <0.01%)
/[language]/sponsors/[id]/[[...slugs]] 4.82 KB 264.03 KB 117.35% (+/- <0.01%)
/[language]/sponsors/[id]/teachings/page/[i] 3.62 KB 262.83 KB 116.81% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 5% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link

github-actions bot commented Jan 7, 2025

Accessibility Issues

CodeNewFixedRetainedIgnoredTotal
WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail00025602560
WCAG2AA.Principle2.Guideline2_4.2_4_1.H64.1000270270
View full summary

Copy link
Contributor

@alangumer alangumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the old images, and convert the new image to JPG since is smaller for web, and translate the content to the other languages.

src/components/molecules/button.module.scss Show resolved Hide resolved
@jlaverde77
Copy link
Contributor Author

Based on the Team Huddle decision on this, this will be closed without merging.

@jlaverde77 jlaverde77 closed this Jan 7, 2025
@jlaverde77 jlaverde77 deleted the AV-1434-Change-Home-page-content-with-Abe-s-update-Website branch January 7, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants