Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add playlist player page #520

Merged
merged 4 commits into from
Mar 11, 2024
Merged

feat: add playlist player page #520

merged 4 commits into from
Mar 11, 2024

Conversation

alangumer
Copy link
Contributor

@alangumer alangumer commented Mar 7, 2024

@alangumer alangumer requested a review from jlaverde77 as a code owner March 7, 2024 21:50
Copy link

vercel bot commented Mar 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
audioverse-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2024 10:07pm

Copy link

github-actions bot commented Mar 7, 2024

📦 Next.js Bundle Analysis for audioverse-next

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 213.34 KB (🟡 +19 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Pages Added

The following pages were added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (225 KB)
/[language]/library/playlists/[id] 2.74 KB 216.08 KB 96.04%
/[language]/playlists/[playlist] 2.74 KB 216.08 KB 96.03%
/[language]/playlists/[playlist]/items/[id]/[[...slugs]] 46.25 KB 259.59 KB 115.37%

Sixty-two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (225 KB)
/404 1.03 KB 214.37 KB 95.28% (+/- <0.01%)
/[language] 9.84 KB 223.18 KB 99.19% (+/- <0.01%)
/[language]/about/1/[[...slugs]] 3.02 KB 216.36 KB 96.16% (+/- <0.01%)
/[language]/about/12/[[...slugs]] 3.7 KB 217.04 KB 96.46% (+/- <0.01%)
/[language]/about/7/[[...slugs]] 3.71 KB 217.05 KB 96.47% (+/- <0.01%)
/[language]/about/[id]/[[...slugs]] 1.85 KB 215.19 KB 95.64% (+/- <0.01%)
/[language]/account/login 43.27 KB 256.61 KB 114.05% (+/- <0.01%)
/[language]/account/loginLanding 40.98 KB 254.32 KB 113.03% (+/- <0.01%)
/[language]/account/preferences 45.41 KB 258.75 KB 115.00% (+/- <0.01%)
/[language]/account/reset 3.97 KB 217.31 KB 96.58% (+/- <0.01%)
/[language]/bibles/[id]/[[...slugs]] 3.3 KB 216.64 KB 96.29% (+/- <0.01%)
/[language]/bibles/[id]/[book]/[chapter] 40.37 KB 253.71 KB 112.76% (🟡 +0.01%)
/[language]/bibles/chapters/[id]/[[...slugs]] 45.29 KB 258.63 KB 114.95% (🟡 +0.06%)
/[language]/blog/[id]/[[...slugs]] 3.71 KB 217.05 KB 96.47% (+/- <0.01%)
/[language]/books/[id]/[[...slugs]] 5.45 KB 218.79 KB 97.24% (+/- <0.01%)
/[language]/books/page/[i] 2.96 KB 216.3 KB 96.13% (🟡 +0.01%)
/[language]/books/tracks/[id]/[[...slugs]] 46.08 KB 259.42 KB 115.30% (🟡 +0.06%)
/[language]/conferences/[id]/[[...slug]] 5.22 KB 218.57 KB 97.14% (+/- <0.01%)
/[language]/conferences/[id]/presenters/page/[i] 3.33 KB 216.67 KB 96.30% (+/- <0.01%)
/[language]/conferences/[id]/sequences/page/[i] 3.32 KB 216.66 KB 96.29% (+/- <0.01%)
/[language]/conferences/page/[i] 2.98 KB 216.32 KB 96.14% (+/- <0.01%)
/[language]/discover 8.37 KB 221.71 KB 98.54% (+/- <0.01%)
/[language]/discover/collections 6.39 KB 219.73 KB 97.66% (+/- <0.01%)
/[language]/egwbooks/page/[i] 2.99 KB 216.33 KB 96.14% (🟡 +0.01%)
/[language]/embed/media/[id] 38.17 KB 251.51 KB 111.78% (🟡 +0.01%)
/[language]/library 47.5 KB 260.84 KB 115.93% (+/- <0.01%)
/[language]/library/history 48.57 KB 261.91 KB 116.40% (+/- <0.01%)
/[language]/library/playlists 48.84 KB 262.18 KB 116.52% (🟡 +0.02%)
/[language]/page/[id]/[[...slugs]] 1.42 KB 214.76 KB 95.45% (+/- <0.01%)
/[language]/presenters/[id]/appears/page/[i] 3.45 KB 216.79 KB 96.35% (+/- <0.01%)
/[language]/presenters/[id]/sequences/page/[i] 3.44 KB 216.79 KB 96.35% (+/- <0.01%)
/[language]/presenters/[id]/teachings/page/[i] 3.58 KB 216.93 KB 96.41% (+/- <0.01%)
/[language]/presenters/[id]/top 1.93 KB 215.27 KB 95.68% (+/- <0.01%)
/[language]/releases/[id] 2.84 KB 216.18 KB 96.08% (+/- <0.01%)
/[language]/search/collections/page/[i] 3.04 KB 216.38 KB 96.17% (+/- <0.01%)
/[language]/search/persons/page/[i] 3.04 KB 216.38 KB 96.17% (+/- <0.01%)
/[language]/search/sequences/page/[i] 3.04 KB 216.38 KB 96.17% (+/- <0.01%)
/[language]/search/sponsors/page/[i] 3.03 KB 216.38 KB 96.17% (+/- <0.01%)
/[language]/search/teachings/page/[i] 3.03 KB 216.37 KB 96.17% (+/- <0.01%)
/[language]/series/[id]/[[...slug]] 5.46 KB 218.8 KB 97.24% (+/- <0.01%)
/[language]/series/page/[i] 2.97 KB 216.31 KB 96.14% (+/- <0.01%)
/[language]/songs/[id]/[[...slugs]] 46.07 KB 259.41 KB 115.29% (🟡 +0.07%)
/[language]/songs/albums 4.71 KB 218.05 KB 96.91% (+/- <0.01%)
/[language]/songs/albums/[id]/[[...slugs]] 5.46 KB 218.8 KB 97.25% (🟢 -0.01%)
/[language]/songs/book/[book] 6.37 KB 219.71 KB 97.65% (+/- <0.01%)
/[language]/songs/book/[book]/[id]/[[...slugs]] 46.23 KB 259.57 KB 115.36% (🟡 +0.07%)
/[language]/sponsors/[id]/[[...slugs]] 4.84 KB 218.18 KB 96.97% (+/- <0.01%)
/[language]/sponsors/[id]/conferences/page/[i] 3.52 KB 216.86 KB 96.38% (+/- <0.01%)
/[language]/sponsors/[id]/series/page/[i] 3.51 KB 216.86 KB 96.38% (+/- <0.01%)
/[language]/sponsors/letter/[letter] 2.29 KB 215.63 KB 95.83% (🟡 +0.01%)
/[language]/stories/[id]/[[...slugs]] 46.07 KB 259.41 KB 115.29% (🟡 +0.07%)
/[language]/stories/albums/[id]/[[...slugs]] 5.46 KB 218.8 KB 97.24% (+/- <0.01%)
/[language]/stories/albums/page/[i] 2.4 KB 215.75 KB 95.89% (+/- <0.01%)
/[language]/teachings/[id]/[[...slug]] 46.07 KB 259.41 KB 115.29% (🟡 +0.07%)
/[language]/teachings/all/page/[i] 3.82 KB 217.16 KB 96.51% (🟡 +0.01%)
/[language]/teachings/audio/page/[i] 3.82 KB 217.16 KB 96.51% (🟡 +0.01%)
/[language]/teachings/trending/all 2.96 KB 216.3 KB 96.13% (🟡 +0.01%)
/[language]/teachings/trending/audio 2.42 KB 215.76 KB 95.89% (+/- <0.01%)
/[language]/teachings/trending/video 2.42 KB 215.76 KB 95.89% (+/- <0.01%)
/[language]/teachings/video/page/[i] 3.82 KB 217.16 KB 96.52% (+/- <0.01%)
/[language]/testimonies/page/[i] 3.11 KB 216.46 KB 96.20% (+/- <0.01%)
/[language]/topics/[id]/[[...slugs]] 4.91 KB 218.25 KB 97.00% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 5% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@alangumer alangumer merged commit a0a5219 into master Mar 11, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants