Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to audb-public repo on S3 #16

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Switch to audb-public repo on S3 #16

merged 2 commits into from
Dec 6, 2024

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Dec 6, 2024

Switch to the audb-public repository on S3 for the published datasets.

Summary by Sourcery

Switch to the 'audb-public' repository on S3 for dataset storage and update CI workflows to include additional audio and video libraries.

Build:

  • Switch to the 'audb-public' repository on S3 for dataset storage.

CI:

  • Update CI workflows to install additional audio and video libraries, including ffmpeg and mediainfo.

Copy link

sourcery-ai bot commented Dec 6, 2024

Reviewer's Guide by Sourcery

This PR switches the repository configuration from JFrog Artifactory to Amazon S3 for published datasets. It updates the repository settings and modifies the CI workflows to include additional media processing dependencies.

Class diagram for Repository configuration update

classDiagram
    class Repository {
        - String name
        - String url
        - String type
    }
    note for Repository "Updated repository configuration"
    Repository : name = "audb-public"
    Repository : url = "s3.dualstack.eu-north-1.amazonaws.com"
    Repository : type = "s3"
Loading

File-Level Changes

Change Details Files
Switch repository configuration from JFrog Artifactory to Amazon S3
  • Change repository name from 'data-public' to 'audb-public'
  • Update host URL to S3 endpoint in eu-north-1 region
  • Change repository type from 'artifactory' to 's3'
repository.py
Update CI workflows with additional media processing dependencies
  • Add ffmpeg and mediainfo to system dependencies
  • Add apt-get update step before installing packages
  • Standardize media library installation steps across workflows
.github/workflows/publish.yml
.github/workflows/doc.yml
.github/workflows/pages.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hagenw - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

  • Missing -r flag in pip install command for requirements file (link)

Overall Comments:

  • There's an inconsistency in the installation of the 'sox' package - it's removed from some workflows while kept in others. Please ensure this is intentional and won't cause any issues.
Here's what I looked at during the review
  • 🔴 General issues: 1 blocking issue
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

.github/workflows/publish.yml Outdated Show resolved Hide resolved
@hagenw hagenw merged commit 2eb6d27 into main Dec 6, 2024
2 checks passed
@hagenw hagenw deleted the switch-to-s3 branch December 6, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant