Ensure transform.Function returns writable arrays #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
hagenw
changed the title
hagenw
changed the title
hagenw
changed the title
audeerington
reviewed
Jul 5, 2024
Co-authored-by: audeerington <[email protected]>
audeerington
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31
I added tests that run all the single transforms on a read-only signal, and none of them fails.
I only can achieve the error when I combine the transforms with another transforms, that sets the signal to read-only.The tests fail for single transforms or combined transforms, see #35 (comment).The error is fixed by copying the signal inside
auglib.transform.Base.__call__(), if it is set to read-only.