Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auglib.transform.PinkNoise for odd samples #24

Merged
merged 5 commits into from
Jan 29, 2024
Merged

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Jan 29, 2024

Closes #23

There was a bug that went noticed for the PinkNoise tests as those included only signals with an even number of samples.

@hagenw hagenw marked this pull request as draft January 29, 2024 12:53
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ef48643) 100.0% compared to head (e81633d) 100.0%.

Additional details and impacted files
Files Coverage Δ
auglib/core/transform.py 100.0% <100.0%> (ø)

@hagenw hagenw marked this pull request as ready for review January 29, 2024 13:05
@hagenw hagenw requested a review from audeerington January 29, 2024 13:06
Copy link
Contributor

@audeerington audeerington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

tests/test_transform_pink_noise.py Outdated Show resolved Hide resolved
@hagenw hagenw merged commit e9fbcb9 into main Jan 29, 2024
9 checks passed
@hagenw hagenw deleted the fix-pink-noise branch January 29, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PinkNoise() can fail with wrong signal length of noise
2 participants