-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove typing module #27
Conversation
Reviewer's Guide by SourceryThis pull request removes the Updated class diagram for type hinting changesclassDiagram
class GoldStandard {
+agreement_categorical(ratings: Sequence, axis: int) float | np.ndarray
+agreement_numerical(ratings: Sequence, minimum: float, maximum: float, axis: int) float | np.ndarray
+evaluator_weighted_estimator(ratings: Sequence, axis: int) float | np.ndarray
+mode(ratings: Sequence, axis: int) object
+rater_agreement(ratings: Sequence, axis: int) np.ndarray
+_value_or_array(values: np.ndarray) float | np.ndarray
+_mode(ratings: np.ndarray, remove_nan: bool) object
}
class Reliability {
+cronbachs_alpha(ratings: Sequence, axis: int) tuple[float, dict]
+congeneric_reliability(ratings: Sequence, axis: int) tuple[float, dict]
+intra_class_correlation(ratings: Sequence, axis: int, icc_type: str, anova_method: str) tuple[float, dict]
}
class Datasets {
+read_dataset(data_set_name: str) pd.DataFrame
+list_datasets() pd.DataFrame
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ChristianGeng - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Hagen Wierstorf <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All fine now.
Purpose
While removing support for Python 3.8 elseqhere, which has reached its end-of-life, typing is refactored. While audpsychometric does not support Python 3.8, it still uses the
typing
module for type hinting which is getting uncommon with more recent python versions e.g.list[str]
for type hinting instead oftyping.List[str]
. I also removed occurrences oftyping.Union
in favor of using|
.typing.Any
is becomingobject
which is the highest type in Python's type hierarchy.