-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop python 3.8 #111
base: main
Are you sure you want to change the base?
Drop python 3.8 #111
Conversation
Reviewer's Guide by SourceryThis PR removes Python 3.8 support and updates type hints to use modern Python syntax. The changes primarily involve replacing Updated class diagram for audobject.core.resolverclassDiagram
class Base {
+str | None root
+object decode(DefaultValueType value)
+DefaultValueType encode(object value)
}
class DefaultValueType {
+bool
+datetime
+dict
+float
+int
+list
+None
+str
}
class LambdaResolver {
+Callable decode(str value)
+str | object encode(Callable value)
+str get_source(Callable func)
+str _get_short_lambda_source(Callable lambda_func)
}
Base <|-- LambdaResolver
Updated class diagram for audobject.core.objectclassDiagram
class Object {
+Mapping~str, object~ arguments
+Mapping~str, str~ borrowed_arguments
+Sequence~str~ hidden_arguments
+Mapping~str, resolver.Base~ resolvers
+Mapping~str, resolver.DefaultValueType~ to_dict()
+Object from_dict(Mapping~str, object~ d, str | None root)
+Object from_yaml(str | io.IOBase path_or_stream)
+void to_yaml(str | io.IOBase path_or_stream)
+void _encode_variable(str name, object value, bool include_version, str | None root)
+object _encode_value(object value, bool include_version)
+Mapping~str, resolver.DefaultValueType~ _flatten(Mapping~str, resolver.DefaultValueType~ d)
+resolver.DefaultValueType _resolve_value(str name, object value, str | None root)
}
Updated class diagram for audobject.core.parameterclassDiagram
class Parameter {
+type value_type
+str description
+object value
+object default_value
+Sequence~object~ choices
+str | None version
+bool __contains__(str | None version)
+void set_value(object value)
+void _check_value(object value)
+void to_path(str delimiter, Sequence~str~ | None include, Sequence~str~ | None exclude, bool sort)
+object __getattribute__(str name)
+void __setattr__(str name, object value)
}
Updated class diagram for audobject.core.dictionaryclassDiagram
class Dictionary {
+KeysView~str~ keys()
+ItemsView~str, object~ items()
+ValuesView~object~ values()
+bool __contains__(str key)
+object __getitem__(str name)
+void __setitem__(str key, object value)
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ChristianGeng - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
Co-authored-by: Hagen Wierstorf <[email protected]>
Co-authored-by: Hagen Wierstorf <[email protected]>
Co-authored-by: Hagen Wierstorf <[email protected]>
Co-authored-by: Hagen Wierstorf <[email protected]>
Co-authored-by: Hagen Wierstorf <[email protected]>
Co-authored-by: Hagen Wierstorf <[email protected]>
Closes #110
This is what has been done to avoid having to use
typing
:Summary by Sourcery
Drop support for Python 3.8 and update type annotations to use modern Python syntax.
Enhancements:
CI:
Chores: