-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add audmodle-internal S3 repo to defaults #6
Conversation
Reviewer's Guide by SourceryThe PR adds a new S3 repository 'audmodel-internal' to the default repositories configuration and updates the authentication documentation. The implementation involves modifying the default repositories list in the config class and updating the related documentation. Class diagram for updated config class with new repositoryclassDiagram
class config {
+Repository[] REPOSITORIES
}
class Repository {
+String name
+String url
+String type
}
config "1" -- "*" Repository : contains
Repository <|-- audmodel-internal : new
class audmodel-internal {
+"audmodel-internal"
+"s3.dualstack.eu-north-1.amazonaws.com"
+"s3"
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hagenw - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please complete the documentation in authentication.rst to include details about required AWS credentials and authentication process for the S3 repository.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Add
audmodle-internal
repository on S3 to the default repositories as configured inaudmodel.config.REPOSITORIES
.It also updates the documentation on authentication accordingly (at the moment, we don't have a public repository):
It also updates the
Repository
to support S3 and MinIO, but different toaudb
we always use theMaven
interface for versioning, to provide a better structure for the_uid
folder, which we use a lookup for model IDs.Summary by Sourcery
Add the 'audmodel-internal' S3 repository to the default configuration and update the documentation to reflect changes in authentication requirements.
New Features:
Documentation: