Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: update ruff and codespell versions #60

Merged
merged 2 commits into from
Dec 16, 2024
Merged

TST: update ruff and codespell versions #60

merged 2 commits into from
Dec 16, 2024

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Dec 16, 2024

Update ruff and codespell pre-commits to the versions we now use in other packages.

Summary by Sourcery

Update the versions of 'ruff' and 'codespell' pre-commit hooks to align with other packages.

Build:

  • Update the version of the 'ruff' pre-commit hook to v0.7.0.
  • Update the version of the 'codespell' pre-commit hook to v2.3.0.

Copy link

sourcery-ai bot commented Dec 16, 2024

Reviewer's Guide by Sourcery

This PR updates the versions of two pre-commit hooks: ruff is upgraded from v0.1.8 to v0.7.0, and codespell is upgraded from v2.2.4 to v2.3.0. The changes are implemented through direct version number updates in the pre-commit configuration file.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update pre-commit tool versions
  • Upgrade ruff from v0.1.8 to v0.7.0
  • Upgrade codespell from v2.2.4 to v2.3.0
.pre-commit-config.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hagenw - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider testing the ruff upgrade locally first, as the version jump from 0.1.8 to 0.7.0 is significant and might introduce new linting behaviors.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@hagenw hagenw merged commit 8a6f1c9 into main Dec 16, 2024
16 checks passed
@hagenw hagenw deleted the update-pre-commit branch December 16, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant