-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for Python 3.8 #161
Conversation
Reviewer's Guide by SourceryThis pull request removes support for Python 3.8 and updates the code to use the new typing syntax introduced in Python 3.9. This includes replacing instances of Class diagram showing updated type annotations in core modulesclassDiagram
class io {
+convert_to_wav(infile: str, outfile: str, offset: float|int|str|np.timedelta64, duration: float|int|str|np.timedelta64, bit_depth: int, normalize: bool, overwrite: bool) void
+read(file: str, duration: float|int|str|np.timedelta64, offset: float|int|str|np.timedelta64, always_2d: bool, dtype: str) tuple[np.array, int]
}
class utils {
+duration_in_seconds(duration: float|int|str|np.timedelta64, sampling_rate: float|int) np.floating
}
class info {
+bit_depth(file: str) int|None
}
note for io "Updated type hints to use | operator"
note for utils "Updated type hints to use | operator"
note for info "Updated Optional to use | None syntax"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hagenw - I've reviewed your changes - here's some feedback:
Overall Comments:
- The PR description mentions removing
typing
but thetyping
imports are still present in the files. Consider either updating the description or removing the unused imports.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
Removes support for Python 3.8 and updates syntax of code to stop using
typing
.Summary by Sourcery
Remove support for Python 3.8.
Build:
Chores:
pyproject.toml
.