DOC: utils.hash() is not influenced by names #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianGeng
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Review
This MR extends testing of the hashing approach for asserting invariance of the hash
- when index name changes for series and data frames
- column names change for data frames.
The resulting hashes are hardcoded which will therefore also detect changes in the unlikely case that the underlying numpy hashing implementation is changed.
This can be counted as approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #434
audformat.utils.hash()does only consider values, not level/column names.To make this more obvious, I added a sentence to the docs:
I also added tests for the expected behavior.