-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.12 #395
Conversation
The test for Python 3.12 worked, but it took 18x times as long as the other tests. I will restart the tests and see if this always happens. |
It takes that long for Python 3.12 as it needs to build the wheel for We should only continue here as soon as |
We cannot support Python 3.12 until it is supported in |
Reviewer's Guide by SourceryThis pull request adds support for Python 3.12. This includes adding a new test job for Python 3.12 and updating the classifiers in pyproject.toml to include Python 3.12. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hagenw - I've reviewed your changes - here's some feedback:
Overall Comments:
- Could you please expand the PR description to include details about your testing process with Python 3.12 and note any compatibility considerations or issues encountered?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Add tests and support for Python 3.12.
Summary by Sourcery
Add support for Python 3.12.
Enhancements:
CI:
Tests: