Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.12 #395

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Add support for Python 3.12 #395

merged 2 commits into from
Jan 17, 2025

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Oct 9, 2023

Add tests and support for Python 3.12.

Summary by Sourcery

Add support for Python 3.12.

Enhancements:

  • Add Python 3.12 classifier to the project metadata.

CI:

  • Add Python 3.12 to the test matrix.

Tests:

  • Add support and tests for Python 3.12.

@hagenw
Copy link
Member Author

hagenw commented Oct 10, 2023

The test for Python 3.12 worked, but it took 18x times as long as the other tests. I will restart the tests and see if this always happens.

@hagenw hagenw marked this pull request as draft October 10, 2023 08:03
@hagenw
Copy link
Member Author

hagenw commented Oct 10, 2023

It takes that long for Python 3.12 as it needs to build the wheel for pandas which takes a very long time.

We should only continue here as soon as pandas wheels for Python 3.12 are available.

@hagenw
Copy link
Member Author

hagenw commented Jan 23, 2024

We cannot support Python 3.12 until it is supported in audb (meaning audbackend) as we use this in docstring example

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.0%. Comparing base (a24114d) to head (85af0c2).
Report is 1 commits behind head on main.

Additional details and impacted files

@hagenw hagenw marked this pull request as ready for review January 17, 2025 17:29
@hagenw hagenw merged commit 53471be into main Jan 17, 2025
11 checks passed
@hagenw hagenw deleted the python-3.12 branch January 17, 2025 17:29
Copy link

sourcery-ai bot commented Jan 17, 2025

Reviewer's Guide by Sourcery

This pull request adds support for Python 3.12. This includes adding a new test job for Python 3.12 and updating the classifiers in pyproject.toml to include Python 3.12.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added a new test job for Python 3.12.
  • Added a new job to the test workflow that runs tests on Python 3.12.
.github/workflows/test.yml
Updated the classifiers in pyproject.toml to include Python 3.12.
  • Added Python 3.12 to the list of supported Python versions in the classifiers.
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hagenw - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Could you please expand the PR description to include details about your testing process with Python 3.12 and note any compatibility considerations or issues encountered?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant