lyricwiki-qt: Add support for chartlyrics.com. Closes: #1217 #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radioactiveman
force-pushed
the
lyricwiki-add-chartlyrics-provider
branch
2 times, most recently
from
71b5781 to
74e4d26
Compare
lyrics.ovh has been unreliable in the past months. Meanwhile it is working again but still has issues at times. Offer chartlyrics.com as an alternative. It is also not perfect with no support for HTTPS and lyrics for new songs are missing. Hoever having a choice is still better. And it is free for non-commercial use, unlike many other sites. See also: - http://www.chartlyrics.com/api.aspx (Terms of Use) - NTag/lyrics.ovh#15 - NTag/lyrics.ovh#17
Found with cppcheck
radioactiveman
force-pushed
the
lyricwiki-add-chartlyrics-provider
branch
from
74e4d26 to
81cc000
Compare
jlindgren90
approved these changes
Jan 17, 2024
radioactiveman
merged commit 8da856e
into
audacious-media-player:master
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lyricwiki-qt: Add support for chartlyrics.com. Closes: #1217
lyrics.ovh has been unreliable in the past months.
Meanwhile it is working again but still has issues at times.
Offer chartlyrics.com as an alternative. It is also not perfect
with no support for HTTPS and lyrics for new songs are missing.
Hoever having a choice is still better. And it is free for
non-commercial use, unlike many other sites.
See also: