-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: universal versioned installer #896
Conversation
intentionally didn't bump universal.sh to see if the ci will automatically correct that when it produces the artifact
ci: universal.sh tagged version build output
} | ||
REF=${{ github.ref }} | ||
TAG=${REF:11} | ||
write_metadata universal.sh sshnp_version "$TAG" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the action is called from a tag, then it will replace the version in the universal.sh script with the version from the tag, then it will upload that as an artifact.
FROM= | ||
|
||
# Receiving (a.k.a. remote) device atSign | ||
TO= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't really encourage people to use this, and it's not up to date, so let's just remove the template. People can still create config files if they want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is for creating a test archive (since the v5.0.2 release doesn't contain all the bits needed by universal.sh), not 100% sure that the linux side works, but it is meant for development.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This readme doesn't really add much value, since it just reiterates the usage of the script.
@@ -1,20 +0,0 @@ | |||
#!/bin/sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced by the metadata functions which overwrite this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the changes here are to formatting.
sed -i '' "$@" | ||
else | ||
sed -i "$@" | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because macos sed -i requires an argument after, and gnu sed expects the argument omitted if there's no backup extension...
echo "$arg_zero [...options] [command]" | ||
echo "Available commands:" | ||
echo "at_activate - install at_activate" | ||
echo "npt - install npt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added npt
echo "" | ||
echo "launchd <unit> - install a launchd unit" | ||
echo " available units: [sshnpd]" | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added launchd
echo "Options:" | ||
echo "-b <dir> - override the directory in which the binaries are written to" | ||
echo "-u <username> - override the user to install the binaries for" | ||
echo "-f <flags> - additional flags services" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added these override flags
# To see all available options, run `srvd` with no arguments. | ||
|
||
# SCRIPT METADATA | ||
binary_path="$HOME/.local/bin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did this so we could remove the separate root version, by simply replacing the string here
# To see all available options, run `sshnpd` with no arguments. | ||
|
||
# SCRIPT METADATA | ||
binary_path="$HOME/.local/bin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing here
|
||
# Uncomment if you wish to have the daemon make various information visible to the manager atsign - e.g. username, version, etc - without the manager atSign needing to know this daemon's device name | ||
; Environment=u="-u" | ||
# Comment if you don't want the daemon to share various information with the manager atsign - e.g. username, version, etc - without the manager atSign needing to know this daemon's device name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default -su on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new script that will included directly as an asset in the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is opinionated and will guide the person through providing the appropriate information to complete installation.
For device installation, the priority order is:
macos : launchd
linux & root : systemd
tmux installed : tmux
fallback : cron
Looks like something I did on this branch is incompatible with the new e2e tests, will need further investigation |
More likely network / atServer weather. I'm re-running the tests now |
succeeded on re-run |
- What I did
- How I did it
- How to verify it
https://github.com/atsign-foundation/noports/releases/tag/v5.1.0-rc.5
- Description for the changelog
feat: universal versioned installer