test: tests for #703 #704
Closed
test: tests for #703 #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs: Added TODOs
…o socket-authenticator-option
…uthentication by SSHRV
…er class to create the right message type
…er class to create the right message type
…esult of many a files uptaking the new name.
…-option # Conflicts: # packages/noports_core/lib/src/sshnp/impl/sshnp_openssh_local_impl.dart # packages/noports_core/lib/src/sshrvd/sshrvd_impl.dart
…o socket-authenticator-option
1. Changes to take args to accept authenticateClient and authenticateDevice args 2. Using the values of these args to make decisions 3. Changes to the way we sign the data
- new sshrv parameters --bind-local-port and --rvd-auth-string - uses new socket_connector method, serverToSocket - multiple other tweaks to get things to work
…d IV in sshrv. Next commit will have the AES key and IV creation, sharing, and passing in to the sshrv process via command line and parameters
- add checkForFinalDeliveryStatus and waitForFinalDeliveryStatus parameters everywhere we call `notify` - make callers use those parameters appropriately. Note that in no case was there a need for those parameters to be true, but it seems better to introduce the parameters and make callers explicitly aware of them, rather than the simpler change to just set them to false in every case.
…s the daemon supports. This is then used to downgrade where the daemon does not support the feature
…ted out two 'return' statements for now, in the runZonedGuarded onError handler
chore: socket-authenticator-option merge renames
…o socket-authenticator-option
…-option # Conflicts: # packages/dart/noports_core/lib/src/sshnp/impl/sshnp_openssh_local_impl.dart # packages/dart/noports_core/lib/src/version.dart # packages/dart/noports_core/pubspec.yaml # packages/dart/sshnoports/pubspec.lock # packages/dart/sshnoports/pubspec.yaml
…en presented as `null`
1. have SshrvdImpl fetch the public key of another atSign via the Sshrvd's own atClient 2. instead of waiting 1 second for a forked sshrv process to have started up, instead listen to its stderr and wait for the message that says "rv is running"
…ds to instance methods
…Rvd, encryptRvdTraffic and discoverDaemonFeatures to false
- if new rvd features (authentication) are NOT being used, send an old-style request - if new rvd features (authentication) ARE being used, send a new-style request
…g because of timeout waiting for sshrvd response
- in ping response, daemon says whether or not it accepts public keys from the client - added abbreviations in SshnpArg for the new flags - corrected some code comments and added to others
|
Same recurrent issue where local-trunk and trunk-local failed because I rename something in the e2e test suite |
|
nvm #703 is running its own set of tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
See #703
#703 is a stack on top of #659
This PR exists to ensure that the tests still pass for the changes in #703
- How I did it
- How to verify it
- Description for the changelog
test: tests for #703