Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies for at commons 4.0.0 #699

Closed
wants to merge 10 commits into from

Conversation

XavierChanth
Copy link
Member

@XavierChanth XavierChanth commented Jan 19, 2024

- What I did

  • Updated locally dependency versions
  • Put in place dependency overrides for at_client,at_onboarding_cli,at_auth,at_server_status on both noports_core and sshnoports
  • Fixed lint errors related to value assertions:
    • Stopped checking whether AtKey.key or AtKey.metadata are null
    • Fixed a potentially null notification.value in the sshrvd_impl notification handler

- How I did it

- How to verify it

  • noports_core Unit tests for lint errors and type errors
  • e2e tests for any functional errors

- Description for the changelog
chore: update dependencies for at commons 4.0.0

@XavierChanth XavierChanth requested a review from gkc January 19, 2024 13:20
@XavierChanth
Copy link
Member Author

Thanks @purnimavenkatasubbu for investigating this further

@gkc we will also have to update the dependencies for sshnp_flutter, it should be as simple as updating the same dependencies as for sshnoports.

@gkc
Copy link
Contributor

gkc commented Jan 20, 2024

All looks fine but I presume this should not be merged until the packages have been published and we can remove the dependency overrides?

Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks fine but I presume this should not be merged until the packages have been published and we can remove the dependency overrides?

@XavierChanth
Copy link
Member Author

@purnimavenkatasubbu can you follow up on this PR when you get a chance?

@purnimavenkatasubbu
Copy link
Member

@XavierChanth I have raised a new PR #767, I think this PR has some missing changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants