feat: remove paramiko and use openssh binary #663
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cpswan @XavierChanth I'm not sure what best practices for versioning and removing paramiko from poetry / requirements.txt are. If you could give me some help there would be greatly appreciated. |
|
I've set this to draft as I think we should have an arch discussion before pushing ahead with this. I'd like to better understand the pros and cons of removing python native capability in exchange for other dependencies. |
|
After discussion in arch, decided to opt for python native solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Removed paramiko which was used for reverse ssh in order to address this code scanning alert
- How I did it
Removed paramiko and used the binary.
- How to verify it
Use a sshnp command like the following
sshnp -f {atsign} -t {atsign} -h {host} -d {device} --legacy-daemon- Description for the changelog
feat: remove paramiko and use openssh binary