Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sshnpd: add --storage-path option #650

Merged
merged 16 commits into from
Jan 1, 2024

Conversation

gkc
Copy link
Contributor

@gkc gkc commented Dec 20, 2023

- What I did

  • Allow user to specify a path for where the sshnpd program keeps any locally stored data

- How I did it

  • See commits

- How to verify it

  • Automated tests pass
  • Manual tests pass - verifiable by checking that the provided storage-path contains the hive boxes once the sshnpd process has started up. Manually tested successfully as follows:
    • bin/sshnpd -a @daemonAtSign -m @clientAtSign -d mbp -v -s -u --storage-path ./sshnpd_storage/@daemonAtSign
    • bin/sshnp -f @clientAtSign -t @daemonAtSign -d mbp -i ~/.ssh/noports -h @rv_eu -s noports.pub -u @USER --idle-timeout 30 --ssh-client dart

- Description for the changelog
feat: sshnpd: add --storage-path option

@gkc gkc requested a review from XavierChanth December 20, 2023 12:27
@gkc gkc marked this pull request as ready for review December 20, 2023 12:27
@gkc gkc requested a review from cconstab December 20, 2023 12:28
@gkc gkc marked this pull request as draft December 20, 2023 12:57
cconstab
cconstab previously approved these changes Dec 20, 2023
@gkc gkc marked this pull request as ready for review December 21, 2023 12:00
…ause multibuild is failing with `Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run` which looks like a known breaking change in v4.0.0 of upload-artifact
@gkc
Copy link
Contributor Author

gkc commented Dec 28, 2023

@cconstab please can you re-review when you get a moment - thanks!

@cconstab
Copy link
Member

We used to have the files in a temp directory so you could run concurrent sshnp without box problems. Just looking at the change here have we lost that or am I missing something ?

Copy link
Member

@cconstab cconstab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used to have these files in a temp directory so you could run concurrent sshnp without hive box problems. Just looking at the change here have we lost that or am I missing something ?

@gkc
Copy link
Contributor Author

gkc commented Jan 1, 2024

We used to have these files in a temp directory so you could run concurrent sshnp without hive box problems. Just looking at the change here have we lost that or am I missing something ?

This is a change to sshnpd, not sshnp

@gkc gkc merged commit 14ce336 into trunk Jan 1, 2024
20 checks passed
@gkc gkc deleted the feat/sshnpd/add-storage-path-option branch January 1, 2024 14:27
@gkc
Copy link
Contributor Author

gkc commented Jan 1, 2024

We used to have these files in a temp directory so you could run concurrent sshnp without hive box problems. Just looking at the change here have we lost that or am I missing something ?

This is a change to sshnpd, not sshnp

But that sshnp feature may well have vanished sometime in the past few months

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants