Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new package-windows script #607

Merged
merged 2 commits into from
Dec 5, 2023
Merged

feat: add new package-windows script #607

merged 2 commits into from
Dec 5, 2023

Conversation

XavierChanth
Copy link
Member

- What I did

  • This only works on macos because I opted to use ditto instead of zip, but we required an apple silicon device to do the release anyways.

- How I did it

- How to verify it

- Description for the changelog
feat: add new package-windows script

@XavierChanth XavierChanth requested a review from cpswan December 5, 2023 16:04
@cpswan cpswan marked this pull request as draft December 5, 2023 16:15
cpswan
cpswan requested changes Dec 5, 2023
View reviewed changes
tools/package-windows-x64.sh Outdated Show resolved Hide resolved
tools/package-windows-x64.sh Show resolved Hide resolved
@XavierChanth XavierChanth requested a review from cpswan December 5, 2023 16:45
@XavierChanth XavierChanth marked this pull request as ready for review December 5, 2023 20:21
@XavierChanth XavierChanth merged commit 45b1ecd into trunk Dec 5, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpswan cpswan cpswan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XavierChanth @cpswan