feat: client side Windows support #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XavierChanth
commented
Nov 10, 2023
| if (!Platform.isWindows) { | ||
| chmod(files[0].path, '600'); | ||
| chmod(files[1].path, '644'); | ||
| } | ||
|
|
There was a problem hiding this comment.
These functions are posix only and don't work on windows, and I didn't have any file permission issues in Windows... It's possible the windows OpenSSH doesn't even check because of how painful it is to do in Windows
XavierChanth
commented
Nov 10, 2023
| @@ -29,9 +29,9 @@ class DefaultSshnpArgs { | |||
| static const List<String> localSshOptions = <String>[]; | |||
| static const bool legacyDaemon = false; | |||
| static const bool listDevices = false; | |||
| static const SupportedSshClient sshClient = SupportedSshClient.exec; | |||
| static const SupportedSshClient sshClient = SupportedSshClient.openssh; | |||
| } | |||
There was a problem hiding this comment.
Renamed all "exec" ssh stuff to "openssh" so we can add support for other execution based ssh programs like dropbear and putty
XavierChanth
commented
Nov 10, 2023
| @@ -79,7 +79,7 @@ class SshnpExecLocalImpl extends SshnpCore | |||
| ); | |||
|
|
|||
| /// Start the initial tunnel | |||
| Process bean = | |||
| Process? bean = | |||
| await startInitialTunnel(identifier: ephemeralKeyPair.identifier); | |||
There was a problem hiding this comment.
The workaround for Windows doesn't allow for handing back a process, thus it will be null on Windows
XavierChanth
commented
Nov 10, 2023
| throw SshnpError( | ||
| 'Windows is not supported by unsigned sshnp clients.', | ||
| ); | ||
| } |
There was a problem hiding this comment.
Disable Windows on the Legacy AKA unsigned client
XavierChanth
commented
Nov 10, 2023
| @@ -55,7 +56,8 @@ mixin SshnpdDefaultPayloadHandler on SshnpdChannel { | |||
| params.sshnpdAtSign, | |||
| logger, | |||
| envelope, | |||
| useFileStorage: useLocalFileStorage, | |||
| useFileStorage: useLocalFileStorage && | |||
| !Platform.isWindows, // disable publickey cache on windows | |||
There was a problem hiding this comment.
public key caching has issues on Windows
gkc
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Description for the changelog
feat: client side Windows support