Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Typos and UI issues addressed. #1640

Merged
merged 20 commits into from
Jan 8, 2025
Merged

fix: Typos and UI issues addressed. #1640

merged 20 commits into from
Jan 8, 2025

Conversation

CurtlyCritchlow
Copy link
Contributor

@CurtlyCritchlow CurtlyCritchlow commented Jan 8, 2025 •
edited
Loading

- What I did

  • Updated App texts for improved grammar, clarity, punctuation and accuracy.
  • Profile relay field retains original size when validation error is shown.
  • "@" is prefixed to atsign fields if left out by user and trailing white space is also automatically removed.
  • Setting Icon replaced with Icon and Text
  • View Switch updated with better colour contrast.
  • Logging checkbox and text swapped for consistency.
  • All Screen Content is centred and stops resizing beyond a certain screen size.

- How I did it

- How to verify it

- Description for the changelog

Fixed Typos and UI inaccuracies.

@CurtlyCritchlow
chore: app messages updated in english.
aa8b699
@CurtlyCritchlow
core: app texts updated to for improved clarity, punctuation, consist…
a5e09b9 
…ent tone and natural phrasing.
@CurtlyCritchlow
chore: missing local port string added.
dbfe287
@CurtlyCritchlow
fix: extra space removed and unused empty string removed.
e7227ec
@CurtlyCritchlow
fix: extra space removed and unused empty string removed.
f672a50
@CurtlyCritchlow
fix: profile relay field maintains size when validation error is show…
8022cb8 
…n and @ is automatically prefixed to the field.
@CurtlyCritchlow
fix: @ is prefixed to field if not entered by the user.
42d2672
@CurtlyCritchlow
fix: setting icon button in app bar replaced with Text Icon button.
a0398cd
@CurtlyCritchlow
fix: settings button on dashboard screen realigned to match logo padd…
31a34e2 
…ing.
@CurtlyCritchlow
fix: dashboard view toggle active color changed to black.
d4e2068
@CurtlyCritchlow
fix: default relay selection switch left aligned.
4048ea6
@CurtlyCritchlow
fix: logging switch shows check box then text.
e4203fa
@CurtlyCritchlow
fix: custom relay buttons updated and title "Custom" added to the rel…
a997975 
…ay text fields.
@CurtlyCritchlow
fix: screen contents are centered and stops resizing beyond a certain…
8dae8e3 
… device size.
@CurtlyCritchlow
chore: backupYourKey english translation updated.
b36d306
@CurtlyCritchlow
fix: trailing white space is automatically removed from device atsign…
d4a3f11 
… text field.
@CurtlyCritchlow
chore: all rights reserved updated to 2025.
6e5fd8e
This was linked to issues Jan 8, 2025
NoPorts Dashboard doesn't check for extra space character #1580
Closed
1.1.5 NoPorts Design Nits #1614
Closed
@CurtlyCritchlow CurtlyCritchlow changed the title 1493 fix typos and UI issues fix: Typos and UI issues addressed. Jan 8, 2025
@CurtlyCritchlow CurtlyCritchlow linked an issue Jan 8, 2025 that may be closed by this pull request
Fix typos and UI issues #1493
Closed
@CurtlyCritchlow CurtlyCritchlow marked this pull request as ready for review January 8, 2025 11:51
XavierChanth
XavierChanth previously approved these changes Jan 8, 2025
View reviewed changes
@CurtlyCritchlow CurtlyCritchlow merged commit 536f114 into trunk Jan 8, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierChanth XavierChanth XavierChanth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@CurtlyCritchlow @XavierChanth