Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update README files for all of the Dart packages #1613

Merged
merged 3 commits into from
Dec 19, 2024
Merged

docs: Update README files for all of the Dart packages #1613

merged 3 commits into from
Dec 19, 2024

Conversation

XavierChanth
Copy link
Member

@XavierChanth XavierChanth commented Dec 11, 2024 •
edited
Loading

- What I did

Updated the various dart package readmes with the latest relevant information:

  • No Ports -> NoPorts
  • noports_core points to npt_flutter instead of sshnp_flutter as it's app example.
  • marked sshnp_flutter as unmaintained and added suggested alternatives
  • Updated sshnoports a little bit, it could use more work, but I'm timeboxing it here.

- How I did it

- How to verify it

- Description for the changelog
docs: Update README files for all of the Dart packages

@XavierChanth XavierChanth requested a review from cpswan December 11, 2024 18:25
cpswan
cpswan requested changes Dec 19, 2024
View reviewed changes
Copy link
Member

@cpswan cpswan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM but can be please use correct capitalisation for CLI.

packages/dart/sshnoports/README.md Outdated Show resolved Hide resolved
packages/dart/sshnoports/README.md Outdated Show resolved Hide resolved
@XavierChanth XavierChanth requested a review from cpswan December 19, 2024 14:29
@XavierChanth XavierChanth merged commit ccf9e7c into trunk Dec 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpswan cpswan cpswan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XavierChanth @cpswan