Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error atsign doesn't exist #1600

Merged
merged 2 commits into from
Dec 7, 2024
+14 −11
Merged

fix: error atsign doesn't exist #1600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
173b44b
fix: yeah I don't even know why I'm needing to do this
XavierChanth Dec 6, 2024
1bbaab9
chore: update version
XavierChanth Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/dart/npt_flutter/lib/features/onboarding/widgets/activate_atsign_dialog.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,10 @@ class _ActivateAtsignDialogState extends State<ActivateAtsignDialog> {
});
} else {
if (!mounted) return;
if (status == ActivationStatus.preparing) {
Navigator.of(context).pop(AtOnboardingResult.error(message: "@${jsonDecode(res.body)["message"]}"));
return;
}
ScaffoldMessenger.of(context).showSnackBar(
SnackBar(
backgroundColor: Colors.red,
Expand Down
21 changes: 10 additions & 11 deletions packages/dart/npt_flutter/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,16 @@ publish_to: "none" # Remove this line if you wish to publish to pub.dev
# https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html
# In Windows, build-name is used as the major, minor, and patch parts
# of the product and file versions while build-number is used as the build suffix.
version: 1.1.3+0
version: 1.1.4+4
msix_config:
display_name: "NoPorts Desktop"
publisher_display_name: Atsign Inc
identity_name: TheCompany.NoPortsDesktop
publisher: CN=BBFE1D0B-F713-4C7F-B375-5EA851CBB1FF
msix_version: 1.1.4.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The msix_version number need to be 1.1.4.0. It will fail Microsoft validation if the last digit is not 0.

logo_path: "assets/logo.png"
capabilities: internetClient
store: true

environment:
sdk: ^3.5.0
Expand Down Expand Up @@ -132,16 +141,6 @@ flutter:
# For details regarding fonts from package dependencies,
# see https://flutter.dev/to/font-from-package

msix_config:
display_name: "NoPorts Desktop"
publisher_display_name: Atsign Inc
identity_name: TheCompany.NoPortsDesktop
publisher: CN=BBFE1D0B-F713-4C7F-B375-5EA851CBB1FF
msix_version: 1.1.3.0
logo_path: "assets/logo.png"
capabilities: internetClient
store: true

flutter_launcher_icons:
android: "launcher_icon"
ios: true
Expand Down
Loading