Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: window behavior #1599

Merged
merged 2 commits into from
Dec 6, 2024
Merged

fix: window behavior #1599

merged 2 commits into from
Dec 6, 2024

Conversation

XavierChanth
Copy link
Member

- What I did

  • Made the window a regular window on all platforms
  • Removed always on top
  • Changed windowManager.focus to windowManager.show
    • On macos these are effectively the same thing, but on Windows they are not.
      • focus will show & focus on mac, but focus will only focus existing Windows on Windows
      • show will show & focus on mac and windows

Macos changes:

  • Always on top = false

Windows changes:

  • Fix show window and show settings buttons
  • Always on top = false

- How I did it

- How to verify it

- Description for the changelog
fix: window behavior

@XavierChanth XavierChanth force-pushed the window-manager branch 2 times, most recently from 8bd3b2f to f2edfa6 Compare December 6, 2024 14:39
@CurtlyCritchlow CurtlyCritchlow merged commit 421b2be into trunk Dec 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants