Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: localization added for the duplicate button. #1561

Merged
merged 2 commits into from
Nov 21, 2024
Merged

fix: localization added for the duplicate button. #1561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3234dae
fix: localization added for the duplicate button.
CurtlyCritchlow Nov 21, 2024
c533702
Merge branch 'trunk' into 1518-npt_atsign_bugs
XavierChanth Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/dart/npt_flutter/lib/features/profile/widgets/profile_popup_menu_button.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import 'package:flutter_bloc/flutter_bloc.dart';
import 'package:flutter_gen/gen_l10n/app_localizations.dart';
import 'package:npt_flutter/app.dart';
import 'package:npt_flutter/features/profile/profile.dart';
import 'package:npt_flutter/pages/profile_form_page.dart';
import 'package:npt_flutter/features/profile_list/bloc/profile_list_bloc.dart';
import 'package:npt_flutter/pages/profile_form_page.dart';
import 'package:npt_flutter/styles/sizes.dart';
import 'package:npt_flutter/widgets/custom_snack_bar.dart';
import 'package:phosphor_flutter/phosphor_flutter.dart';
Expand Down Expand Up @@ -53,7 +53,7 @@ class ProfilePopupMenuButton extends StatelessWidget {
children: [
PhosphorIcon(PhosphorIcons.copy()),
gapW10,
const Text("Duplicate"), // TODO: localizations
Text(strings.duplicate),
],
),
onTap: () {
Expand Down
2 changes: 1 addition & 1 deletion packages/dart/npt_flutter/lib/localization/app_en.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{

"addNew" : "Add New",
"addNewProfile" : "Add New Profile",
"advanced": "Advanced",
Expand Down Expand Up @@ -27,6 +26,7 @@
"disconnected" : "disconnected",
"discord" : "Discord",
"done": "Done",
"duplicate" : "Duplicate",
"edit" : "Edit",
"email" : "Email",
"emptyProfileMessage" : "No profiles found\nCreate or Import a profile to start using NoPorts.",
Expand Down
1 change: 1 addition & 0 deletions packages/dart/npt_flutter/lib/localization/app_es.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
"disconnected" : "desconectado",
"discord" : "Discord",
"done": "Hecho",
"duplicate" : "Duplicar",
"edit" : "Editar",
"email" : "Correo electrónico",
"emptyProfileMessage" : "No se encontraron perfiles\nCree o importe un perfil para comenzar a usar NoPorts.",
Expand Down
1 change: 1 addition & 0 deletions packages/dart/npt_flutter/lib/localization/app_pt.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
"disconnected" : "desconectado",
"discord" : "Discord",
"done": "Concluído",
"duplicate" : "Duplicar",
"edit" : "Editar",
"email" : "Email",
"emptyProfileMessage" : "Nenhum perfil encontrado\nCrie ou Importe um perfil para começar a usar NoPorts.",
Expand Down
1 change: 1 addition & 0 deletions packages/dart/npt_flutter/lib/localization/app_pt_BR.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
"disconnected" : "desconectado",
"discord" : "Discord",
"done": "Concluído",
"duplicate" : "Duplicar",
"edit" : "Editar",
"email" : "Email",
"emptyProfileMessage" : "Nenhum perfil encontrado\nCrie ou Importe um perfil para começar a usar NoPorts.",
Expand Down
1 change: 1 addition & 0 deletions packages/dart/npt_flutter/lib/localization/app_zh.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
"disconnected" : "断开连接",
"discord" : "Discord",
"done": "完成",
"duplicate" : "重复",
"edit" : "编辑",
"email" : "电子邮件",
"emptyProfileMessage" : "未找到配置文件\n创建或导入配置文件以开始使用NoPorts。",
Expand Down
1 change: 1 addition & 0 deletions packages/dart/npt_flutter/lib/localization/app_zh_Hans_CH.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
"disconnected" : "断开连接",
"discord" : "Discord",
"done": "完成",
"duplicate" : "重复",
"edit" : "编辑",
"email" : "电子邮件",
"emptyProfileMessage" : "未找到配置文件\n创建或导入配置文件以开始使用NoPorts。",
Expand Down
1 change: 1 addition & 0 deletions packages/dart/npt_flutter/lib/localization/app_zh_Hant_HK.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
"disconnected" : "已斷開",
"discord" : "Discord",
"done": "完成",
"duplicate" : "重複",
"edit" : "編輯",
"email" : "電子郵件",
"emptyProfileMessage" : "未找到配置文件\n創建或導入配置文件以開始使用NoPorts。",
Expand Down
2 changes: 1 addition & 1 deletion packages/dart/npt_flutter/macos/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,4 +87,4 @@ SPEC CHECKSUMS:

PODFILE CHECKSUM: 236401fc2c932af29a9fcf0e97baeeb2d750d367

COCOAPODS: 1.15.2
COCOAPODS: 1.14.3
4 changes: 2 additions & 2 deletions packages/dart/npt_flutter/pubspec.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1549,10 +1549,10 @@ packages:
dependency: transitive
description:
name: vm_service
sha256: f652077d0bdf60abe4c1f6377448e8655008eef28f128bc023f7b5e8dfeb48fc
sha256: "5c5f338a667b4c644744b661f309fb8080bb94b18a7e91ef1dbd343bed00ed6d"
url: "https://pub.dev"
source: hosted
version: "14.2.4"
version: "14.2.5"
watcher:
dependency: transitive
description:
Expand Down