Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: exclude policy admin webapp assets from the docker distributions #1539

Merged
merged 5 commits into from
Nov 17, 2024

Conversation

gkc
Copy link
Contributor

@gkc gkc commented Nov 17, 2024

- What I did

  • build: include policy admin API but exclude policy admin webapp assets from the docker distributions
  • Context: (a) installing node slows down the dockerfile build quite a lot; (b) required version of node is not available as standard (i.e. via apt-get) for the platforms in question so can't (currently) build the webapp anyway (c) if required, the webapp assets can be copied from other downloads

- How I did it

  • Removed the node install and npm build steps from tools/multibuild/Dockerfile.package
  • Additionally, although unrelated, now specifying npm version to use when building the webapp assets in multibuild.yaml main_build

- How to verify it
Manually verified by running multibuild workflow against this branch - see https://github.com/atsign-foundation/noports/actions/runs/11878280981/job/33098772780

@XavierChanth
Copy link
Member

We can always offer a second docker image for the web app and provide an example compose file of how to run both. Although, they have no internal dependencies so there's no special configuration, they just need the same atsign.

@gkc gkc merged commit 9d11710 into trunk Nov 17, 2024
18 of 19 checks passed
@gkc gkc deleted the multibuild-set-npm-version branch November 17, 2024 13:19
@gkc
Copy link
Contributor Author

gkc commented Nov 17, 2024

We can always offer a second docker image for the web app and provide an example compose file of how to run both. Although, they have no internal dependencies so there's no special configuration, they just need the same atsign.

@XavierChanth yes; also could copy the web assets into the docker file from a pre-docker-file-build step

@XavierChanth
Copy link
Member

We can always offer a second docker image for the web app and provide an example compose file of how to run both. Although, they have no internal dependencies so there's no special configuration, they just need the same atsign.

@XavierChanth yes; also could copy the web assets into the docker file from a pre-docker-file-build step

I wasn't planning on working on it until we have an ask.

@cpswan
Copy link
Member

cpswan commented Nov 17, 2024

I can take a look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants