Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 32bit support #1494

Merged
merged 2 commits into from
Nov 5, 2024
Merged

fix: 32bit support #1494

merged 2 commits into from
Nov 5, 2024

Conversation

XavierChanth
Copy link
Member

- What I did

  • Changed long cast to int64_t where we have a timeout which exceeds 4 bytes (30 days in milliseconds for device_info expiry)
  • I also snuck in some .clangd changes as our recent introduction of the shared clangd settings is using the default std (some c++ version), instead of our desired c99

- How I did it

- How to verify it

- Description for the changelog
fix: 32bit support

@XavierChanth XavierChanth requested a review from cpswan November 5, 2024 18:52
@@ -2,7 +2,7 @@ CompileFlags:
# Use gcc in development for better diagnostics
# & Ensure that compilation doesn't fail due to warnings
Compiler: gcc
Add: [-Wno-error]
Add: [-Wno-error, -xc, -std=c99]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-xc = use the C language instead of the default -xc++

@XavierChanth XavierChanth merged commit f608213 into trunk Nov 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants