Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add onboarding screen to npt flutter #1428

Merged
merged 27 commits into from
Oct 16, 2024

Conversation

CurtlyCritchlow
Copy link
Contributor

- What I did
added onboarding screen and dialog to npt_flutter
- How I did it

- How to verify it
run the app and onboard.
- Description for the changelog

@CurtlyCritchlow CurtlyCritchlow linked an issue Oct 7, 2024 that may be closed by this pull request
Copy link
Member

@XavierChanth XavierChanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one change - move the root domain dialog out of main flow

@XavierChanth XavierChanth force-pushed the 1412-add-onboarding-screen-to-npt-flutter branch from 3db992f to a4f738f Compare October 9, 2024 00:13
@XavierChanth
Copy link
Member

There are some edge cases I caught when testing. I will make those changes early next week.

@XavierChanth XavierChanth requested review from gkc and cpswan October 16, 2024 20:53
@gkc gkc dismissed XavierChanth’s stale review October 16, 2024 21:56

Changes have been made

@XavierChanth XavierChanth merged commit 96ca97e into trunk Oct 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add onboarding screen to npt flutter
3 participants