fix: allow leading underscore in device name #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds compatibility re device name validation.
gkc
commented
Oct 7, 2024
| List<String> args = '-a @daemon'.split(' '); | ||
| await expectLater( | ||
| () => SshnpdParams.fromArgs(args), | ||
| await expectLater(() => SshnpdParams.fromArgs(args), |
gkc
commented
Oct 7, 2024
| @@ -54,5 +54,5 @@ class DefaultSshnpdArgs { | |||
| static const String deviceGroupName = '__none__'; | |||
| static const String sshPublicKeyPermissions = ""; | |||
| static const Duration policyHeartbeatFrequency = Duration(minutes: 5); | |||
| static const String permitOpen ='localhost:22,localhost:3389'; | |||
| static const String permitOpen = 'localhost:22,localhost:3389'; | |||
gkc
commented
Oct 7, 2024
| @@ -26,7 +26,7 @@ void main() { | |||
| final p = await SshnpdParams.fromArgs(args); | |||
| expect(p.deviceAtsign, '@daemon'); | |||
| expect(p.policyManagerAtsign, '@policy'); | |||
| expect(p.managerAtsigns, ['@bob','@chuck']); | |||
| expect(p.managerAtsigns, ['@bob', '@chuck']); | |||
sitaram-kalluri
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
fix: allow leading underscore in device name to preserve full backwards compatibility re device name validation.
- How I did it
- How to verify it
Tests pass
- Additional context
Follow-on from #1420