feat: BETA: policy service using atServer as backing store; admin API and UI #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e supplies a permitOpen list - made daemonAtsigns injectable via npa bootstrapper - added permitOpen to NPAAuthCheckResponse - renamed `SshnpdImpl.isFromAuthorizedAtsign` to `authCheck` and have it return an NPAAuthCheckResponse - use the NPAAuthCheckResponse to further check authorization for npt requests. After the SshnpdImpl checks its own permitOpen list, it will now also check the permitOpen list returned by the npa policy service. This enables nice single-jump-box configurations where the jump-box daemon could have permitOpen "*:*" but individual client atSigns may be restricted to "my_host:3389" or "*:22" or whatever is appropriate - added policy binary to the buildArchive and buildBinaries scripts, and to the multibuild.yaml workflow definition
fix: fixed a couple of small bugs uncovered during first road-test
…atServer for persistence
…cy-service # Conflicts: # packages/dart/sshnoports/pubspec.lock
- universal.sh - shell/install.sh - shell/headless/sshnpd.sh - shell/launchd/com.atsign.sshnpd.plist - shell/systemd/sshnpd.service
… this is just the same atSign as the policy service itself) with details of every request received and the decision that was made
Had to change docker context from a nested folder to the root of the repo.
- rename admin_api/bin/admin_api.dart to np_admin.dart (standardize on np prefix for our binaries) - rename sshnoports/bin/npa_file.dart to npp_file.dart (npp for NoPortsPolicy) - rename sshnoports/bin/npp.dart to npp_atserver.dart - update multibuild.yaml - reflect the renames from above - put the np_admin and npp_atserver binaries into sshnp/beta, and the admin webapp files into sshnp/beta/web - add npp_file, npp_atserver and np_admin to the list of binaries for MacOS code signing - update Dockerfile.package - reflect the renames from above - put the np_admin and npp_atserver binaries into sshnp/beta, and the admin webapp files into sshnp/beta/web
gkc
commented
Sep 5, 2024
| @@ -85,8 +91,21 @@ jobs: | |||
| dart compile exe bin/activate_cli.dart -v -o sshnp/at_activate${{ matrix.ext }} | |||
| dart compile exe bin/sshnp.dart -v -o sshnp/sshnp${{ matrix.ext }} | |||
| dart compile exe bin/npt.dart -v -o sshnp/npt${{ matrix.ext }} | |||
| dart compile exe bin/npp_file.dart -v -o sshnp/npa_file${{ matrix.ext }} | |||
| dart compile exe bin/npp_file.dart -v -o sshnp/npp_file${{ matrix.ext }} | |||
There was a problem hiding this comment.
standardizing on npp_ prefix for all policy binaries; given we had npa_file out there already, preserving it for now
…tibuild build(deps): Update dependabot for new Dockerfile location
XavierChanth
reviewed
Sep 5, 2024
| dart compile exe bin/sshnp.dart -v -o /sshnp/sshnp; \ | ||
| dart compile exe bin/npt.dart -v -o /sshnp/npt; \ | ||
| dart compile exe bin/npp_file.dart -v -o /sshnp/npp_file; \ | ||
| ln -s sshnp/npp_file sshnp/npa_file; \ |
There was a problem hiding this comment.
Multibuild did not like this:
https://github.com/atsign-foundation/noports/actions/runs/10721898228/job/29731556532
I think it is okay to make breaking changes in the alpha release and just remove npa_file and leave in npp_file
There was a problem hiding this comment.
I see why, needs to be absolute path, but I still don't think a symbolic link in the release is a good idea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Note that this is still only alpha quality but the intention is that will be beta quality in our 5.7.0 release
- How I did it
See commits
- How to verify it
TODO in subsequent PRs