ci: policy docker build #1310
Merged
ci: policy docker build #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Had to change docker context from a nested folder to the root of the repo.
XavierChanth
commented
Sep 4, 2024
There was a problem hiding this comment.
This file was moved to tools/multibuild.yaml
XavierChanth
commented
Sep 4, 2024
Comment on lines
+8
to
+11
| # install node for later (keep at the top file to increase cache hits) | ||
| # hadolint ignore=DL3008 | ||
| RUN apt-get update; \ | ||
| apt-get install -y --no-install-recommends npm |
There was a problem hiding this comment.
Install npm for the angular app
XavierChanth
commented
Sep 4, 2024
| dart compile exe bin/activate_cli.dart -v -o /sshnp/at_activate; \ | ||
| dart compile exe bin/sshnp.dart -v -o /sshnp/sshnp; \ | ||
| dart compile exe bin/npt.dart -v -o /sshnp/npt; \ | ||
| dart compile exe bin/npa_file.dart -v -o /sshnp/npa_file; \ |
There was a problem hiding this comment.
Added npa_file build
XavierChanth
commented
Sep 4, 2024
Comment on lines
+35
to
+38
| # Build apps/admin/admin_api | ||
| WORKDIR /noports/apps/admin/admin_api | ||
| RUN dart pub get --enforce-lockfile; \ | ||
| dart compile exe bin/admin_api.dart -v -o /sshnp/admin_api |
XavierChanth
commented
Sep 4, 2024
Comment on lines
+40
to
+45
| # Build apps/admin/webapp | ||
| WORKDIR /noports/apps/admin/webapp | ||
| RUN npm install; \ | ||
| npm run build; \ | ||
| mkdir -p /sshnp/web/admin; \ | ||
| cp -r ./dist /sshnp/web/admin |
There was a problem hiding this comment.
Build the angular app
XavierChanth
commented
Sep 4, 2024
Comment on lines
+13
to
+16
| COPY . . | ||
|
|
||
| # Build packages/dart/sshnoports | ||
| WORKDIR /noports/packages/dart/sshnoports |
There was a problem hiding this comment.
Changed some pathing here, the new build context is the root of the repo instead of packages/dart so that the apps directory is also within the context (docker context doesn't work with ../ paths)
XavierChanth
commented
Sep 4, 2024
Comment on lines
-174
to
-176
| defaults: | ||
| run: | ||
| working-directory: ./packages/dart |
There was a problem hiding this comment.
Don't change working directory anymore, use the root of the repo
XavierChanth
commented
Sep 4, 2024
| @@ -195,15 +200,17 @@ jobs: | |||
| uses: docker/setup-buildx-action@988b5a0280414f521da01fcc63a27aeeb4b104db # v3.6.1 | |||
| - if: ${{ ! inputs.main_build_only }} | |||
| run: | | |||
| docker buildx build -t atsigncompany/sshnptarball -f sshnoports/tools/Dockerfile.package \ | |||
| docker buildx build -t atsigncompany/sshnptarball -f ./tools/multibuild/Dockerfile.package \ | |||
XavierChanth
commented
Sep 4, 2024
There was a problem hiding this comment.
Besides the changes noted, the rest of the file is prettier formatting
gkc
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
See https://github.com/atsign-foundation/noports/actions/runs/10708485526
- How I did it
- How to verify it
- Description for the changelog