Skip to content

Commit

Permalink
test: e2e_all: remove 5.0.2 from the client matrix until I've impleme…
Browse files Browse the repository at this point in the history
…nted the `expect` magic to allow the 5.x clients to run even though there is not a real terminal attached. (Note: The latest 5.1.0 build has defensive code added so that it doesn't just crash when there is no terminal attached)
  • Loading branch information
gkc committed Mar 15, 2024
1 parent 5b2dd8d commit f1a71d1
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/e2e_all.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,5 @@ jobs:
echo "Running tests"
tests/e2e_all/scripts/run_all.sh @apricoteventual @combinedbelgian @rv_am \
-w 10 -z 15 \
-s 'd:4.0.5 d:5.0.2 d:current' -c 'd:4.0.5 d:5.0.2 d:current' \
-s 'd:4.0.5 d:5.0.2 d:current' -c 'd:4.0.5 d:current' \
-t all
22 changes: 21 additions & 1 deletion tests/e2e_all/scripts/run_all.sh
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,28 @@ function usageAndExit {
atDirectoryHost=root.atsign.org
atDirectoryPort=64
testsToRun="noop"
defaultDaemonVersions="d:4.0.5 d:current"

defaultDaemonVersions="d:4.0.5 d:5.0.2 d:current"

# Client Versions
# Don't re-add 5.0.x until we've implemented the required
# `expect` magic to allow the 5.x clients to run even though there is not
# a real terminal attached.
# To see what I mean - run sshnp 5.0.2 with piped input - for example
# sshnoports % /Users/gary/dev/atsign/repos/sshnoports/tests/e2e_all/releases/dart.5.0.2/sshnp/sshnp -f @garycasey -t @rv_ap -h @rv_ap -u atsign -d gkc -i ~/.ssh/noports <<< 'echo hello'
# Unhandled exception:
# StdinException: Error getting terminal line mode, OS Error: Inappropriate ioctl for device, errno = 25
# #0 Stdin.lineMode (dart:io-patch/stdio_patch.dart:116)
# #1 main (file:///Users/runner/work/noports/noports/packages/dart/sshnoports/bin/sshnp.dart:38)
# #2 _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:295)
# #3 _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:184)
#
# i.e. basically doesn't work in scripting environments
#
# version 5.1.0+ does work in scripting environments
#
defaultClientVersions="d:4.0.5 d:current"

daemonVersions=$defaultDaemonVersions
clientVersions=$defaultClientVersions

Expand Down

0 comments on commit f1a71d1

Please sign in to comment.