Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Deprecated warnings fixed #942

Draft
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

CurtlyCritchlow
Copy link
Contributor

@CurtlyCritchlow CurtlyCritchlow commented Nov 20, 2024

Fixes #905

- What I did

  • Replace depreciated withOpacity method with withValues in at_common_flutter, at_onboarding_flutter.
    These fixes on the beta channel results in errors on the stable channel.

- How I did it

- How to verify it

- Description for the changelog

@CurtlyCritchlow CurtlyCritchlow linked an issue Nov 20, 2024 that may be closed by this pull request
@cpswan
Copy link
Member

cpswan commented Nov 21, 2024

Thanks @CurtlyCritchlow

My inclination here is to hold off on making these changes until Flutter 3.25 is stable. We have --no-fatal-infos for the tests that run against stable. So the deprecation warnings won't cause stable channel static analysis to fail. We can then make changes that will work for both 3.25 and 3.26 as they'll both support withvalues.

👀 @gkc @XavierChanth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve beta channel deprecation warnings
2 participants