Skip to content

Commit

Permalink
Merge pull request #231 from atsign-foundation/fixAnalyzerIssues
Browse files Browse the repository at this point in the history
fix: Fix dart analyzer issues
  • Loading branch information
murali-shris authored Oct 19, 2022
2 parents b6fb0db + 2eb0a88 commit 2d338d5
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 5 deletions.
8 changes: 4 additions & 4 deletions at_utils/lib/src/atmetadata_utils.dart
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,15 @@ class AtMetadataUtil {
return ttbMs;
}

static int? validateTTR(int? ttr_ms) {
if (ttr_ms == null || ttr_ms == 0) {
static int? validateTTR(int? ttrMs) {
if (ttrMs == null || ttrMs == 0) {
return null;
}
if (ttr_ms <= -2) {
if (ttrMs <= -2) {
throw InvalidSyntaxException(
'Valid values for TTR are -1 and greater than or equal to 1');
}
return ttr_ms;
return ttrMs;
}

/// Throws [InvalidSyntaxException] if ttr is 0 or null.
Expand Down
3 changes: 3 additions & 0 deletions at_utils/lib/src/logging/atsignlogger.dart
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// ignore_for_file: non_constant_identifier_names

import 'package:at_utils/src/logging/handlers.dart';
import 'package:collection/collection.dart' show IterableExtension;
import 'package:logging/logging.dart' as logging;
Expand Down Expand Up @@ -33,6 +35,7 @@ class AtSignLogger {

bool isLoggable(String value) => (LogLevel.level[value]! >= logger.level);

// ignore: unnecessary_getters_setters
bool get hierarchicalLoggingEnabled {
return _hierarchicalLoggingEnabled;
}
Expand Down
2 changes: 1 addition & 1 deletion at_utils/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: A Dart library that contains various utility classes such as atSign
version: 3.0.11
repository: https://github.com/atsign-foundation/at_tools
homepage: https://atsign.dev
documentation: https://atsign.dev/docs/
documentation: https://docs.atsign.com/


environment:
Expand Down

0 comments on commit 2d338d5

Please sign in to comment.